Add Symfony 8 support#10
Open
fguimier wants to merge 3 commits into
Open
Conversation
- Widen symfony/serializer and symfony/filesystem constraints to ^6.0|^7.0|^8.0 - Refresh stale CI matrices (were PHP 8.1/8.2 x Symfony 6.0-6.2): phpunit on PHP 8.1 + 8.4, skeleton smoke test on PHP 8.4 x Symfony 7.4/8.1 - Convert @dataProvider annotations to attributes (required by PHPUnit >= 12) - Update decode test expectations: PhpSpreadsheet 3.x toArray() returns formatted strings for numeric cells, matching current production behavior; the old typed expectations dated from the Symfony 6 / PhpSpreadsheet 1.x matrix Tests pass on both symfony/serializer 7.4.14 and 8.1.1 (PHP 8.4). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The lock was resolved on PHP 8.4 (symfony/serializer 7.4 requires PHP >= 8.2), which broke 'composer install' on the PHP 8.1 matrix job. Libraries should not pin a lock: the phpunit workflow now runs 'composer update' so each matrix PHP version resolves its own compatible dependency set (8.1 -> serializer 6.4, 8.4 -> serializer 8.x). Cache key moved to composer.json accordingly. Note: the 'PHP Linting' workflow failure is pre-existing (since Jan 2026): .php-cs-fixer.php-highest.php aborts unless it runs on PHP 8.1 while the php-cs-fixer-ga docker image has moved to a newer PHP. Left for a dedicated maintenance pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…track the lock symfony/test-pack resolves PHPUnit 9.6 on PHP 8.1, which ignores the #[DataProvider] attributes (metadata attributes require PHPUnit >= 10). Require phpunit/phpunit ^10.5||^11||^12||^13 directly instead - the test suite only uses plain TestCase. Also actually removes composer.lock from the index (the previous commit re-added it by mistake). Verified: PHP 8.1 platform resolves PHPUnit 10.5 / serializer 6.4; PHP 8.4 resolves PHPUnit 13 / serializer 8.1 - tests 4/4 on 8.4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests pass on both symfony/serializer 7.4.14 and 8.1.1 (PHP 8.4).